Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-default-class -> data-default #1010

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

9999years
Copy link
Contributor

data-default 0.8 deprecates data-default-class by moving the Default class from Data.Default.Class to Data.Default.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545


Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazu-yamamoto kazu-yamamoto merged commit 0c31f35 into yesodweb:master Oct 29, 2024
@kazu-yamamoto
Copy link
Contributor

Merged.
Thanks!

@Vlix
Copy link
Contributor

Vlix commented Nov 2, 2024

Ah, this is the PR that broke warp-tls.

Did the CI actually pass on this?

(With "broke" I mean, you can't build the new warp-tls on ANY Stackage LTS if you don't also enforce tls-2.1.2, which I feel is enormously unnecessary for a dependency that adds zero value)

@kazu-yamamoto
Copy link
Contributor

I have removed ">= 0.8" from warp-tls.
Sorry for your inconvenience.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 30, 2025
## 3.1.17

* Started deprecation of `data-default` [#1011](yesodweb/wai#1011)
  * All `Default` instances have comments that these will be removed in a future major version.
  * `def` exported from `Network.Wai.Middleware.Gzip` now has a deprecation warning
  * All uses of `def` have been replaced with explicit `default{TYPE_NAME}` values.
* Some additional documentation

## 3.1.16

* Substituted `data-default-class` for `data-default` [#1010](yesodweb/wai#1010)
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 1, 2025
## 3.4.12

* Rethrowing asynchronous exceptions
  [#1013](yesodweb/wai#1013)

## 3.4.11

* Removing `unliftio`.

## 3.4.10

* Removed `data-default` dependency entirely. Does now require `>= tls-2.1.3`.
  [#1011](yesodweb/wai#1011)

## 3.4.9

* Using `timeout` for `handshake` to prevent thread leaks.

## 3.4.8

* Substituted `data-default-class` for `data-default` [#1010](yesodweb/wai#1010)

## 3.4.7

* Expose `attachConn` to use post-handshake TLS connection.
  [#1007](yesodweb/wai#1007)

## 3.4.6

* Preparing for tls v2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants