Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using keyboard "Enter" command does not apply when a search has already been made #325

Closed
necioerrante opened this issue Nov 11, 2017 · 7 comments
Milestone

Comments

@necioerrante
Copy link

After making an initial search, my example below vlc
If you click search icon (top right corner) and change search, my example fx file
Search will not take place on "Enter" key from keyboard, it just returns to current search
However selecting search from drop dow menu will search again for new keyword

Expected behaviour

When clicking "Enter" key, new search should take place

Actual behaviour

Returns to current search list

Steps to reproduce

  1. Search for vlc
  2. click search icon (top right corner) and change search, I.E. fx file
  3. Click "Enter" key from keyboard
  4. Returns to Search list
    Tested both AOSP keyboard and Hackers Keyboard

@rancidfrog
Copy link

[0.30] Search still does not work when clicking 'Enter' key from keyboard when already in search.
To reproduce:

  • Click Search icon in Appslist view
  • Enter search keywords and click Enter key
  • Search works
  • Now, click Search icon in Search view
  • Type in new search keywords and click 'Enter' key from keyboard when already in search view.
  • Returns to Search view, no new search, not works

@avently
Copy link

avently commented Nov 24, 2017

@rancidfrog he have known about that since July #228
He thinks it's ok and we want it more than alternative

@yeriomin
Copy link
Owner

I'd welcome a pull request which fixes this and does not break anything else.

@avently No need to twist my words.

He thinks it's ok

No, I think fixing this is not a good idea if it makes the app incompatible with old devices or breaks the search history.

we

Never said anything about you. People want different and sometimes contradicting things. You are not the only user.

@avently
Copy link

avently commented Nov 27, 2017

@yeriomin

Тогда заноют пользователи.

Я - пользователь. Следовательно "мы" я сказал как раз к месту. Don't twist your words.
А по поводу PR. Я себе сделал, но не знаю, будет ли это работать на старых андроидах и проверить негде.

@nagayev
Copy link

nagayev commented Dec 2, 2017

@avently себе сделал говоришь?
кинь apk,у меня есть гаджет на 2.3.6 и 4.2.2 могу проверить.

@avently
Copy link

avently commented Dec 2, 2017

yalpstore.zip
@nagayev Тут есть и другие изменения, которые делал для себя. Скачанный .zip файл переименовать в .apk.

@avently
Copy link

avently commented Dec 14, 2017

@nagayev ну и, проверил?

yeriomin added a commit that referenced this issue Jan 2, 2018
@yeriomin yeriomin added this to the 0.34 milestone Jan 2, 2018
@yeriomin yeriomin closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants