Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check fails silently if the token is stale #322

Closed
yeriomin opened this issue Nov 9, 2017 · 3 comments
Closed

Update check fails silently if the token is stale #322

yeriomin opened this issue Nov 9, 2017 · 3 comments
Milestone

Comments

@yeriomin
Copy link
Owner

yeriomin commented Nov 9, 2017

Expected behaviour

Update list or an error message should be displayed

Actual behaviour

Empty list is displayed, no attempt to relogin is made.

Steps to reproduce

  1. Log in with the built-in account
  2. Wait until auth token is invalid
  3. Check for updates

In this case Google does not answer with the standard 401 error, instead an ordinary blank answer is returned.

@JonnyTech
Copy link

Aha - that explains why I have to log out then back in to see updates. How long is the token valid for before it goes stale?

yeriomin added a commit that referenced this issue Nov 9, 2017
@yeriomin
Copy link
Owner Author

yeriomin commented Nov 9, 2017

@JonnyTech Depends on other users' activity. This is not related to #311, because it is not really a timeout. When a new token is issued for the same account, the old tokens seem to be invalidated now. This is relatively recent, and there is still no fix for the shared built-in account, except detecting an error and doing the request again with a new token.

If you use your own account, this does not happen.

@yeriomin
Copy link
Owner Author

yeriomin commented Nov 9, 2017

Making any other request before the update check fixes this by making Yalp Store autorefresh the auth token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants