Up coverage result on coveralls

[mazerte]

Everything is in title.

[SBoudrias]

Hi, your test need some work to be of better quality. First of all, review our testing guidelines.

it('#shift()') doesn't mean anything. Methods level belongs in describe blocks, and it block must contains the expected behavior. Example:

describe('#shift()', function () {
    it('return the first item in the conflict lists');
    it('remove the first item');
});

it('conflict status skip') is not a good name. It state a context, not what is expected. It should be it('does X when status is "skip"').

it('appendFiles should work with css file') is not a good name. Describe block should be #appendFiles(), and it('work with css files'). Never use should in an it block; it is just verbose and add no value.

Don't use Inquirer and event emitting during test. It currently adds a lot of unecessary overhead. Instead, mock the prompt method directly with Sinon.js and return dummy data.

Last thing, try putting less setup code in each it blocks. Prefer using beforeEach for setup (adding conflicts, etc).

[SBoudrias]

@mazerte Any chance you can address the precedent comments?

[mazerte]

I'm sorry Simom, I didn't have time to do this. But I can fix my unit test for follow your guidelines.

I don't undertand how to test Inquirer responses with Sinon.js. I follow your test method in Inquirer repository. https://github.com/SBoudrias/Inquirer.js/blob/master/test/specs/inquirer.js#L42

[SBoudrias]

Yes, I test it this way in Inquirer because I test the Inquirer implementation. In the context of Yeoman, you test Yeoman, not Inquirer and the readline. As so, you only need to mock (override) the Adapter prompt method for your own mocked one. For example:

beforeEach(function () {
    this.promptReturns = { status: 'force' };
    mockAdapter.prompt = function (questions, cb) {
        cb(this.promptReturns);
    });
});

[sindresorhus]

ping :)

[SBoudrias]

@mazerte still around?

[sindresorhus]

Closing for lack for lack of response. We would be happy to reopen if you get interested again though :)

[SBoudrias]

Leave it open, I'll take care of the fixes myself if we don't get them before I get there.

[sindresorhus]

Can we get this landed or closed?

[SBoudrias]

Ok, that's done - thanks for the initial work @mazerte, it's been very useful!