-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouped Queue #475
Grouped Queue #475
Conversation
Extract installation tests in its own module
I would be in favour of adding it directly inside. If there's a chance npm/bower can get repeatedly called we want to avoid that. |
Now Conflicter#resolve is only called once after all method ran Now Base#installDependencies is called once at the end unless --skip-install is passed as option. (This required some changes in test so not every Generator test spawned an install process)
Updated that. Note though that only I also added a commit so tasks having the name (or hash) of a queue are runned in that queue. I'll probably refactor the |
I was thinking about this and there's probably a bug inside it. I'm pretty sure the first prototype method will always run first no matter what (grouped-queue starting running as soon as the first task is appended). So, I guess I'll need to order how tasks are added to the runLoop. I'll refactor the run method to be lighter at the same time. |
Given the significance of that particular queue issue, let's wait until you've had a chance to confirm the issue and fix before moving ahead. |
Ok, finally I was scared for nothing, the weren't any bug :) I added a test ensuring this though, and while looking I found some edge case and easy refactoring. It is now cleaner and stronger! |
We'll need good beta testing on this one! |
Follow up PR to issue #433
I still need to:
Run the prototype methods as part of their relevant queue groupFix issue where Grouped-Queue will always set default as the last queue (I'll change that in the plugin)Add a "run only once" option to Grouped-Queue so install is not called for every composed GeneratorATM, I add
#installDependencies()
in the end queue inside the#run()
method. I wonder if this should not be taken care of inside#installDependencies()
itself? (That would prevent issues where npm and bower are called multiple times if old Generators still call#installDependencies()
manually).