Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every install method should respect --skip-install flag #745

Closed
SBoudrias opened this issue Jan 22, 2015 · 6 comments
Closed

Every install method should respect --skip-install flag #745

SBoudrias opened this issue Jan 22, 2015 · 6 comments

Comments

@SBoudrias
Copy link
Member

ATM only installDependencies() accept a manually passed argument, but doesn't use the global flag.

Also, this doesn't match on documentation on the subject: http://yeoman.io/authoring/dependencies.html

Code wise this mean moving to skip install flag check into runInstall().

@hemanth
Copy link
Member

hemanth commented Jan 23, 2015

That's like adding:

if (options.skipInstall) {
    return options.callback();
  }

or

if (!options.skipInstall) {
   // rest 
  }

here ?

@eddiemonge
Copy link
Member

This is working a bit wonky on generator-webapp (gulp) when using it with composeWith as the target. Not sure if that generator-needs to be updated but it does install the version of this that has this fix. The this.options.skipInstall is false even though this.options['skip-install'] is true in the main generator and the composed generator-webapp.

@SBoudrias
Copy link
Member Author

Currently I guess you need to pass it down the stack manually.

We probably should automatize the global level options being passed down.

@eddiemonge
Copy link
Member

In the generators that I've seen, they use skip-install instead of 'skipInstall`. Switch to the dash version fixes it

@eddiemonge
Copy link
Member

I don't actually see where it gets camelCased like that

@SBoudrias
Copy link
Member Author

@eddiemonge it's done by meow on the yo side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants