inTmpDir changes original behavior of inDir

[blai]

The intention of the second parameter of inDir was discussed/introduced here.

The var release in inTmpDir does not seem to do anything (but I could be wrong). Suggested change here is to change inTmpDir like so

RunContext.prototype.inTmpDir = function (cb) {
  var tmpdir = path.join(os.tmpdir(), crypto.randomBytes(20).toString('hex'));
  return this.inDir(tmpdir, cb);
};

Thoughts?

[SBoudrias]

That make sense to me. But couldn't you just use .on('ready')?

[blai]

Not really. Let's say I am trying to preload some files into the target directory so I can run some test for the scenario of running a yeoman generator with existing contents. .on('read') would not tell me what the actual target directory path is (assuming I use inTmpDir so that path is basically random).

[SBoudrias]

FWIW, when you're inside the ready event, process.cwd() will be the temp directory as we're in the exact context a generator will be runned.

[blai]

Ah, good point, I will look into using that, thanks for the tip.