#inDir() fires after generator is setup #565
Comments
|
Ah! That's the issue, good catch! |
|
issue with something else or this? |
|
I think there's been a report of a similar bug somewhere. You just pinned the cause :) |
blai
pushed a commit
to blai/generator
that referenced
this issue
May 28, 2014
blai
pushed a commit
to blai/generator
that referenced
this issue
May 29, 2014
blai
pushed a commit
to blai/generator
that referenced
this issue
May 29, 2014
… chance to alter the environment to the a specific way and expect `env` and `generator` reflects such settings. Also emits `ready` event right before calling `generator.run()` to allow any last minute operation on the `generator` fixes yeoman#565
blai
pushed a commit
to blai/generator
that referenced
this issue
May 30, 2014
… chance to alter the environment to the a specific way and expect `env` and `generator` reflects such settings. Also emits `ready` event right before calling `generator.run()` to allow any last minute operation on the `generator` fixes yeoman#565
blai
pushed a commit
to blai/generator
that referenced
this issue
Jun 4, 2014
… a chance to alter
the environment to the a specific way and expect `env` and `generator` reflects such
settings.
- Emits `ready` event right before calling `generator.run()` to allow any
last minute operation on the `generator`
- Deprecating `onEnd`, instead emits 'end' event as `generator.on('end')`
- Implement `withGenerator()` to mock generator dependencies
- accepts optional second parameter in `inDir` as a callback function.
fixes yeoman#564, yeoman#565, yeoman#573
blai
pushed a commit
to blai/generator
that referenced
this issue
Jun 4, 2014
… a chance to alter
the environment to the a specific way and expect `env` and `generator` reflects such
settings.
- Emits `ready` event right before calling `generator.run()` to allow any
last minute operation on the `generator`
- Deprecating `onEnd`, instead emits 'end' event as `generator.on('end')`
- Implement `withGenerator()` to mock generator dependencies
- accepts optional second parameter in `inDir` as a callback function.
fixes yeoman#564, yeoman#565, yeoman#573
blai
pushed a commit
to blai/generator
that referenced
this issue
Jun 4, 2014
… a chance to alter
the environment to the a specific way and expect `env` and `generator` reflects such
settings.
- Emits `ready` event right before calling `generator.run()` to allow any
last minute operation on the `generator`
- Deprecating `onEnd`, instead emits 'end' event as `generator.on('end')`
- Implement `withGenerator()` to mock generator dependencies
- accepts optional second parameter in `inDir` as a callback function.
fixes yeoman#564, yeoman#565, yeoman#573
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
this means things like
this.config.pathis set to whatever directory the script is in before changing to the one supplied in.inDir(). This makes testing things like saving config harder..run()should wait to process entries until after inDir has finishedThe text was updated successfully, but these errors were encountered: