Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift5 #222

Merged
merged 7 commits into from
Sep 13, 2019
Merged

Swift5 #222

merged 7 commits into from
Sep 13, 2019

Conversation

usatie
Copy link
Member

@usatie usatie commented Sep 13, 2019

Description of the Change

Update Swift language version to Swift5.0.

Alternate Designs

None.

Benefits

ABI Stability

Possible Drawbacks

Swift4.2 or earlier projects

Applicable Issues

closes #221

usatie and others added 4 commits September 13, 2019 12:45
- Unnecessary public/internal modifier
- Deprecated encodedOffset
- Switch fallthrough
iOS/Linux
- Data(bytes:) to Data()
- index(of:) to firstIndex(of:)
- Refactor deprecated withUnsafeBytes() methods. UnsafePointer<T> -> UnsafeRawBufferPointer

Linux
- RunLoopMode to RunLoop.Mode
- Update Package.swift swift-tools-version to 5.0
@usatie usatie added the roadmap label Sep 13, 2019
@usatie usatie self-assigned this Sep 13, 2019
Remove unnecessary comment
Copy link
Member Author

@usatie usatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usatie usatie merged commit 493071b into master Sep 13, 2019
@usatie usatie deleted the swift5 branch September 13, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Swift5 and resolve warnings
1 participant