change library openssl to secp256k1 for converting priv key to pub key #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usatie
reviewed
Sep 12, 2019
There was a problem hiding this comment.
Thank you @pebble8888.
LGTM, but need rebase and fix tests on Linux.
I'll do it on another branch so I close this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
My motivation is a removal of the openssl library.
Using secp256k1 library which already in use is better than using openssl BIGNUM.
We can remove openssl library eventually.
Alternate Designs
None.
Benefits
see above.
Possible Drawbacks
None.
All unit tests passed in iOS simulator.
Applicable Issues
None.