Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✏️ add public #171

Merged
merged 2 commits into from
Sep 27, 2018
Merged

✏️ add public #171

merged 2 commits into from
Sep 27, 2018

Conversation

akifuji
Copy link
Contributor

@akifuji akifuji commented Sep 27, 2018 •
edited
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

  • Change access modifiers of HDKeychain functions as public
  • Rename the root key of HDKeychain a rootKey

Alternate Designs

Do nothing

Benefits

Users can use HDKeychain class, which enables them to implement HDWallet as they like.

Possible Drawback

Applicable Issues

usatie
usatie approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@usatie usatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akifuji akifuji merged commit 4470cd6 into master Sep 27, 2018
@akifuji akifuji deleted the feature/make-HDKeychain-properties-public branch September 27, 2018 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usatie usatie usatie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akifuji @usatie