Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mock unlock script builder #167

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Refactor mock unlock script builder #167

merged 2 commits into from
Sep 21, 2018

Conversation

usatie
Copy link
Member

@usatie usatie commented Sep 21, 2018

Description of the Change

public typealias SigKeyPair = (signature: Data, key: PublicKey)
protocol MockUnlockScriptBuilder {
    func build(pairs: [SigKeyPair]) -> Script
}

Alternate Designs

public typealias SigKeyPair = (signature: Data, key: PublicKey)
public typealias MockUnlockScriptBuilder = (([SigKeyPair]) -> Script)

Benefits

Able to enforce the function structure.

akifuji
akifuji approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@akifuji akifuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usatie usatie merged commit bb89029 into master Sep 21, 2018
@usatie usatie deleted the refactor-MockUnlockScriptBuilder branch September 21, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akifuji akifuji akifuji approved these changes

Assignees

@akifuji akifuji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@usatie @akifuji