♻️ Remove the direct dependency to secp256k1 #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently
Crypto.swift
andScriptMachine.swift
has a direct dependency to secp256k1.So, remove the dependency.
Alternate Designs
Each users copy
Libraries/secp256k1
, and then set this path toSWIFT_INCLUDE_PATHS
.Benefits
This PR enables Binary build installation.
Possible Drawbacks
For Linux, it is not solved yet.
Applicable Issues
closes #160