Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qrcode convertible #158

Merged
merged 5 commits into from
Sep 18, 2018
Merged

Add qrcode convertible #158

merged 5 commits into from
Sep 18, 2018

Conversation

usatie
Copy link
Member

@usatie usatie commented Sep 17, 2018 •
edited
Loading

closes #157

Description of the Change

  • Add QRCodeGenerator and QRCodeConvertible
  • Remove unnecessary swiftlint disable next
  • Rename Key.raw to Key.data,
  • Refactor Bech32

Benefits

Now everyone can display QRCode image without writing specific codes for that.

  • PrivateKey, PublicKey, HDPrivateKey, HDPublicKey
  • Address

Possible Drawbacks

None.

Applicable Issues

None.

@usatie
✨ Add QRCodeGenerator and QRCodeConvertible
72c620e
@usatie
♻️
c5e23a3 
- Remove unnecessary swiftlint disable next
- Rename Key.raw to Key.data,
- Refactor Bech32
@usatie usatie added the enhancement New feature or request label Sep 17, 2018
@usatie usatie requested a review from akifuji September 17, 2018 06:16
akifuji
akifuji reviewed Sep 17, 2018
View reviewed changes
Sources/BitcoinKit/Core/Keys/QRCodeConvertible.swift Outdated
// BitcoinKit
//
// Created by Shun Usami on 2018/09/16.
// Copyright © 2018 BitcoinKit developers. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify copyright, looking at other files

@akifuji
Copy link
Contributor

akifuji commented Sep 17, 2018

I think that the issue you try to close is different. It should be #157.

@usatie
Copy link
Member Author

usatie commented Sep 17, 2018

@akifuj
Modified copyrights and issue number.
But cannot pass CI, so let me check it.

@usatie
Copy link
Member Author

usatie commented Sep 17, 2018

CI build passed.

akifuji
akifuji approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@akifuji akifuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usatie usatie merged commit ae1ff03 into master Sep 18, 2018
@usatie usatie deleted the add-qrcode-convertible branch September 18, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akifuji akifuji akifuji approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement String -> UIImage (QRCode) feature
2 participants
@usatie @akifuji