Repository navigation
test: support Pi 1.0.2 HTML renderer callbacks - #3
Merged
Merged
Conversation
…xtures Pi 1.0.2 renamed the createToolHtmlRenderer dependency getToolDefinition to getToolRenderers, so the fixtures resolved no tools and calm export rendering looked empty. Pass both keys so the tests run on Pi before and after 1.0.2. Product code does not use this dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Do not merge the worktree-trust fix (PR #2) past its failing check; fix the cause first. The failing check is CI shard "Behavior portable serial 6": tests/fm-calm-pi-extension.test.sh fails with "Pi calm renderer and lifecycle contract failed: grep disappeared from /export calm.html HTML while calm mode was on". CI installs @earendil-works/pi-coding-agent unpinned (.github/workflows/ci.yml around lines 118 and 222); the last green main run used 1.0.0 and Pi 1.0.2 was published 2026-10-04T00:56Z. The test passes locally with Pi 1.0.0.
What Changed
getToolRendererscallbacks to calm export and branch HTML renderer test fixtures for Pi 1.0.2 compatibility.getToolDefinitioncallbacks for compatibility with earlier Pi versions.Risk Assessment
✅ Low: The bounded fixture update corrects the source-confirmed Pi 1.0.2 callback rename at every affected construction while preserving Pi 1.0.0 compatibility and existing behavioral assertions.
Testing
Inspected the test-only diff and ran both affected checks successfully, including existing native Calm E2E checks. Logs were retained in the evidence directory; no visual artifacts were captured. Pi 1.0.2 acceptance remains unverified.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
git diff b6b3f3a30959ab085c9c57599a87a7f67fc9d069 2e3e032ec039fe18af5c0c8c68cb0c1f5d31c5e1pi --version— 0.87.1bash tests/fm-calm-pi-extension.test.sh— exit 0bash tests/fm-pi-branch-extension.test.sh— exit 0git status --short— clean✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.