Claim uuid

[g4s8]

#388 - claim uuids instead of long ids

[0crat]

Job #389 is now in scope, role is REV

[0crat]

This pull request #389 is assigned to @krzyk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

[0crat]

Job gh:zerocracy/datum#389 already assigned to @krzyk, can't assign to @krzyk

[0crat]

Job gh:zerocracy/datum#389 already assigned to @krzyk, can't assign to @krzyk

[krzyk]

@g4s8 please see my comment

[krzyk]

@g4s8 I think it would be easier to migrate, if you leave the field name as id, but change the type to string.
And after all the numeric id are processed, change this id type to uuid.

If we leave it with two optional id and uuid, farm will need to be able to process both types, which will unnecessary complicate it - and then remove it. There is no point in adding that temporary complexity.

[g4s8]

@krzyk done, please see

[krzyk]

@g4s8 thanks

[krzyk]

@rultor merge

[rultor]

@rultor merge

@krzyk Thanks for your request. @g4s8 Please confirm this.

[g4s8]

@rultor merge

[rultor]

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@g4s8 Done! FYI, the full log is here (took me 7min)

[0crat]

Job was finished in 18 hours, bonus for fast delivery is possible (see §36)

[0crat]

@ypshenychka/z please review this job completed by @krzyk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #389 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @g4s8/z

[ypshenychka]

@krzyk According to our QA Rules:

The code reviewer found at least three problems in the code.
Comments were mostly about design problems, not cosmetic issues.

Only one issue was found during code review.
Please confirm that you'll try to find at least three major problems while future reviews.

[krzyk]

@ypshenychka I confirm

[ypshenychka]

@krzyk thanks

[ypshenychka]

@0crat quality acceptable

[0crat]

Order was finished, quality is "acceptable": +20 point(s) just awarded to @krzyk/z

[0crat]

Quality review completed: +8 point(s) just awarded to @ypshenychka/z