-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No TIcket] put back code to rank puzzles #375
base: master
Are you sure you want to change the base?
Conversation
@yegor256 please review |
@@ -78,6 +78,16 @@ def group(xml) | |||
# Take some puzzles from the XML and either close their tickets in GitHub | |||
# or create new tickets. | |||
def expose(xml, tickets) | |||
close(xml, tickets) | |||
skip_model = xml.xpath('/puzzles[@model="true"]').empty? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbao01 I think this flag should be taken from .0pdd
configuration file, not from XML
@mbao01 I think it's better to introduce a new decorator of |
No description provided.