Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No TIcket] put back code to rank puzzles #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbao01
Copy link
Contributor

@mbao01 mbao01 commented Aug 23, 2022

No description provided.

@mbao01
Copy link
Contributor Author

mbao01 commented Aug 23, 2022

@yegor256 please review

@0crat
Copy link
Collaborator

0crat commented Aug 23, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@@ -78,6 +78,16 @@ def group(xml)
# Take some puzzles from the XML and either close their tickets in GitHub
# or create new tickets.
def expose(xml, tickets)
close(xml, tickets)
skip_model = xml.xpath('/puzzles[@model="true"]').empty?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbao01 I think this flag should be taken from .0pdd configuration file, not from XML

@yegor256
Copy link
Owner

@mbao01 I think it's better to introduce a new decorator of Tickets, which will accepts all submit() requests, put them into some in-memory array, do the ranking of it, and then send submit() requests to the encapsulated tickets

@0crat
Copy link
Collaborator

0crat commented Aug 28, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Sep 2, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Sep 7, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Sep 12, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Sep 17, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Sep 22, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Sep 27, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Oct 2, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Oct 7, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Oct 12, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Oct 17, 2022

@yegor256/z everybody who has role REV is banned at #375; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants