[#312] add todo comments

0pdd.rb

@@ -380,6 +380,8 @@ def merged(hash)
 end
 
 def storage(repo)
+  # @todo #312:30min Handle the use case where projects from different vcs have
+  #  the same <user/repo_name>. This will cause a conflict.
   SyncStorage.new(
     UpgradedStorage.new(
       SafeStorage.new(
@@ -424,7 +426,7 @@ def process_request(vcs)
             vcs,
             Job.new(
               vcs,
-              storage(vcs.repo.name, vcs.name),
+              storage(vcs.repo.name),
               SentryTickets.new(
                 EmailedTickets.new(
                   vcs,

objects/jobs/job.rb

@@ -30,19 +30,14 @@ def initialize(vcs, storage, tickets)
     @vcs = vcs
     @storage = storage
     @tickets = tickets
-    @initial_puzzles = nil
   end
 
   def proceed
     @vcs.repo.push
-    @initial_puzzles = @storage.load
+    before = @storage.load
     Puzzles.new(@vcs.repo, @storage).deploy(@tickets)
     return if opts.include?('on-scope')
-    Diff.new(@initial_puzzles, @storage.load).notify(@tickets)
-  rescue Octokit::ClientError => e
-    # TODO: this is a temporary solution, we should use a logger
-    save(@initial_puzzles) if @initial_puzzles
-    throw e
+    Diff.new(before, @storage.load).notify(@tickets)
   end
 
   private

objects/log.rb

@@ -30,6 +30,8 @@
 class Log
   def initialize(dynamo, repo)
     @dynamo = dynamo
+    # @todo #312:30min Be sure to handle the use case where projects from
+    #  different vcs have the same <user/repo_name>. This will cause a conflict.
     @repo = repo
   end