Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pre Commit hook #68

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Added Pre Commit hook #68

merged 5 commits into from
Oct 15, 2024

Conversation

shreypandey
Copy link
Contributor

@shreypandey shreypandey commented Oct 11, 2024

Since parse_obj is deprecated by pydantic in favour of model_validate, changes the calls appropriately in lsp_client.py.

@shreypandey shreypandey changed the title Removed deprecated method call in lsp client Added Pre Commit hook Oct 11, 2024
@shreypandey
Copy link
Contributor Author

shreypandey commented Oct 11, 2024

Added pre-commit hooks for the linting and test cases.
Fixes the issue #36

@shreypandey shreypandey mentioned this pull request Oct 12, 2024
@yeger00
Copy link
Owner

yeger00 commented Oct 13, 2024

Hi @shreypandey , thanks for your contribution
It looks good overall, I will take a deeper look at the evening.

@yeger00 yeger00 self-requested a review October 15, 2024 12:27
@yeger00
Copy link
Owner

yeger00 commented Oct 15, 2024

Do you know if there is an easy way to put the pre-commit as part of the CI?

@shreypandey
Copy link
Contributor Author

@yeger00 Generally precommit hook is for local development. You can setup github actions which will get triggered with each PR.

@yeger00 yeger00 merged commit 5a47454 into yeger00:main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants