Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor fixes #17

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Two minor fixes #17

merged 2 commits into from
Jan 4, 2021

Conversation

smathot
Copy link
Contributor

@smathot smathot commented Dec 22, 2020

I've been working on adding LSP support to Rapunzel, a code editor focused on Python and R. This PR contains two minor fixes that were required to get things to work.

- Add CompletionItemKind
- Don't require containerName in SumbolInformation
@smathot
Copy link
Contributor Author

smathot commented Dec 23, 2020

I also added a timeout to the endpoint. I found that this is useful for buggy language servers that hang on a request. The way I deal with it in the client is that when a timeout occurs, the language server is killed and restarted.

@yeger00
Copy link
Owner

yeger00 commented Jan 4, 2021

Hi,
Thanks for the contribution!

@yeger00 yeger00 merged commit fc6e645 into yeger00:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants