reconfigure nbd device on disconnect from the kernel #2791 #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpashkin
changed the title
tpashkin
commented
Jan 3, 2025
| @@ -108,9 +108,9 @@ TFuture<NProto::TError> TNetlinkDevice::Start() | |||
| ConnectSocket(); | |||
| Connect(); | |||
|
|
|||
| } catch (const TServiceError& e) { | |||
| } catch (const std::exception& e) { | |||
There was a problem hiding this comment.
The reasoning behind handling only TServiceError was that we wanted the caller to deal with ConnectSocket exceptions, but in reality we forgot about it and just crashed the proxy
tpashkin
force-pushed
the
users/tpashkin/nbd-reconnect
branch
from
16f9f52 to
78e08eb
Compare
antonmyagkov
reviewed
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now implementing only for endpoint proxy, because it's our primary use case