Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shirly/scss #1

Merged
merged 6 commits into from
Jan 27, 2019
Merged

Shirly/scss #1

merged 6 commits into from
Jan 27, 2019

Conversation

shirlyfang
Copy link
Collaborator

Configured project to support scss

Copy link
Owner

@ycyvonne ycyvonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you have both package-lock.json as well as yarn.lock files. Yarn and NPM are different package managers, and typically we want to stick with only one (so that they don't conflict with each other). Would recommend removing package-lock.json, removing node_modules then re-running yarn install.

@ycyvonne
Copy link
Owner

According to this issue (facebook/create-react-app#6099), others might need to also remove node_modules and re install.

@shirlyfang shirlyfang merged commit 0bd2ac8 into master Jan 27, 2019
@ycyvonne ycyvonne deleted the shirly/scss branch April 26, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants