Closed
Conversation
added 2 commits
October 30, 2025 07:03
…v_a using fused_rms_fp8_group_quant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fusion of rmsnorm + group scale FP8 quantization (group_size=128)
This PR use the triton kernel from main branch of Rocm/aiter : ROCm/aiter#1148
w/o fusion
w/ fusion

Modifications
deepseek.py
f8.py
fp8_utils.py
Accuracy Tests
python3 benchmark/gsm8k/bench_sglang.py --num-questions 2000 --parallel 2000 --port 8008w/. fused_rms_quant at LayerCommunicator and DeepseekV2AttentionMLA
Accuracy: 0.961
Invalid: 0.000
Latency: 55.205 s
Output throughput: 2412.560 token/s
w/. fused_rms_quant at LayerCommunicator
Accuracy: 0.960
Invalid: 0.000
Latency: 55.688 s
Output throughput: 2366.073 token/s
w/o fused_rms_quant
Accuracy: 0.957
Invalid: 0.000
Latency: 57.499 s
Output throughput: 2302.590 token/s
Benchmarking and Profiling
docker image : docker.io/rocm/sgl-dev:v0.5.3.post2-rocm700-mi35x-20251016
Model : DeepSeek-R1-0528/
Server Mode
docker.io/rocm/sgl-dev:v0.5.3.post2-rocm700-mi35x-20251016
Offline Mode
Checklist