WIP - re-add update function to alerts as data client#13
Merged
dhurley14 merged 9 commits intoyctercero:lets_do_thisfrom May 24, 2021
Merged
WIP - re-add update function to alerts as data client#13dhurley14 merged 9 commits intoyctercero:lets_do_thisfrom
dhurley14 merged 9 commits intoyctercero:lets_do_thisfrom
Conversation
…horization client on plugin start contract
yctercero
approved these changes
May 19, 2021
Owner
yctercero
left a comment
yctercero
left a comment
There was a problem hiding this comment.
LGTM, still not sure why Ying's changes are showing up.
dhurley14
changed the title
yctercero
pushed a commit
that referenced
this pull request
May 25, 2021
* WIP - creating alerting authorization client factory and exposing authorization client on plugin start contract * Updating alerting feature privilege builder to handle different alerting types * Converting to es query if requested * first pass at getting everything working again * working update function * fix rebase conflicts * fixes index mapping to add owner field * fixes update route, previously using wrong ruleTypeId and not building the correct index * fix getIndex function Co-authored-by: Ying Mao <ying.mao@elastic.co>
yctercero
added a commit
that referenced
this pull request
Jun 24, 2021
Addresses PR feedback to generalize util params.
yctercero
added a commit
that referenced
this pull request
Jun 30, 2021
Addresses PR feedback to generalize util params.
yctercero
added a commit
that referenced
this pull request
Jul 5, 2021
Addresses PR feedback to generalize util params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers