Skip to content

ci: enable arm64 in build matrix (linux/amd64,linux/arm64) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ycpss91255 merged 2 commits into from
Apr 24, 2026
Merged

ci: enable arm64 in build matrix (linux/amd64,linux/arm64) #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c55dc5b
ci: enable arm64 in build matrix (linux/amd64,linux/arm64)
ycpss91255 Apr 24, 2026
b4f9e10
ci: bump template @tag to v0.10.0-rc2 for arm64 test-tools fix
ycpss91255 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,15 @@ on:

jobs:
call-docker-build:
uses: ycpss91255-docker/template/.github/workflows/build-worker.yaml@v0.9.13
uses: ycpss91255-docker/template/.github/workflows/build-worker.yaml@v0.10.0-rc2
with:
image_name: ros1_bridge
build_runtime: true
platforms: linux/amd64,linux/arm64

call-release:
needs: call-docker-build
if: startsWith(github.ref, 'refs/tags/')
uses: ycpss91255-docker/template/.github/workflows/release-worker.yaml@v0.9.13
uses: ycpss91255-docker/template/.github/workflows/release-worker.yaml@v0.10.0-rc2
with:
archive_name_prefix: ros1_bridge
1 change: 1 addition & 0 deletions doc/changelog/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ versioning follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
- `COPY config/ /config/` from Dockerfile and the `config directory exists` smoke test — the `/config/` directory was never read at runtime (entrypoint only loads `/bridge.yaml`). `config/*.yaml` files remain in the repo as reference examples and can still be consumed via `--build-arg BRIDGE_FILE=config/<file>.yaml`.

### Fixed
- **CI matrix did not include arm64.** PR #23 rebuilt `devel` from a multi-arch base for Jetson support, but `.github/workflows/main.yaml` never opted in to the template's arm64 build matrix (default is `linux/amd64` only). Pass `platforms: linux/amd64,linux/arm64` to `build-worker.yaml` so CI now actually verifies arm64 on every push, instead of relying on manual rsync-to-Jetson testing.
- **arm64 / Jetson `./build.sh test` failure (closes template #106).** Dockerfile's inline `bats-src` / `bats-extensions` / `lint-tools` stages had hardcoded `linux.x86_64` / `Linux-x86_64` download URLs, so on arm64 hosts they pulled unusable binaries and the `test` stage exited at `shellcheck -S warning /lint/*.sh`. Migrated to template's arch-aware pre-built test-tools image (v0.9.13 D plan): top-level `ARG TEST_TOOLS_IMAGE="test-tools:local"` default keeps local `./build.sh` flow unchanged (builds `Dockerfile.test-tools` into host Docker daemon); CI overrides to `ghcr.io/ycpss91255-docker/test-tools:v0.9.13` via `GITHUB_WORKFLOW_REF` parsing in `build-worker.yaml`. New `FROM ${TEST_TOOLS_IMAGE} AS test-tools-stage` alias; 4 `COPY --from=test-tools:local` → `--from=test-tools-stage`. 3 inline stages deleted, net ~15 lines removed.
- Restore `.env.example` (removed during APT-mirror refactor) so `setup.sh`'s IMAGE_NAME detection has its documented fallback.

Expand Down
Loading