chore: upgrade .base to v0.35.0 + fix hadolint CI failure#120
Merged
Conversation
4246dfd chore: release v0.35.0 (#422) 1889914 chore: release v0.35.0-rc1 (#421) 8fc56b6 refactor(dockerfile): remove pip/setup scaffolding — downstream owns pip (closes #407) (#419) d57dce1 refactor(dockerfile): hadolint ignore cleanup — pin versions, fix violations (closes #405) (#418) 3e37af6 feat(build-worker): support extra_stages input for custom Dockerfile stages (closes #415) (#417) 0d29af7 feat(setup.conf): add [network] pid for PID namespace mode (closes #412) (#413) 0d8d683 fix(Makefile): guard VAR=VALUE args + fix absolute path forwarding (closes #414) (#416) a61636f fix(upgrade.sh): anchor #399 idempotency regex to prevent /lint/script/ false-positive (closes #403) (#404) bb54db8 chore: release v0.34.1 (#401) e63daf2 feat(upgrade.sh): auto-patch Dockerfile COPY *.sh /lint/ post-#330 drift (#400) git-subtree-dir: .base git-subtree-split: 4246dfde95ec54b053b52931f59317c7acbe19fb
- main.yaml: workflow @tag updated to v0.35.0 - .gitignore: synced canonical entries (template lib/gitignore.sh) - untracked any derived artifacts now covered by .gitignore
…ignores
DL3006 (always tag image version) fires on `FROM ${BASE_IMAGE}`
which is variable-based by design for multi-distro support.
DL3003 (use WORKDIR) fires on `cd /lint` in the test stage which
is an ephemeral lint context, not a real WORKDIR need.
Previously .hadolint.yaml was a symlink to .base/.hadolint.yaml
which only carries the 4 base ignores (DL3004/DL3008/DL3013/DL3018).
ros1_bridge needs repo-specific ignores so break the symlink and
maintain a standalone file.
Fixes the pre-existing CI failure on main branch push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
.basesubtree from v0.34.0 to v0.35.0 and fix pre-existinghadolint CI failure.
Changes
.basesubtree upgrade to v0.35.0 (auto-committed byupgrade.sh): picks up base PR#416 Makefile fix (VAR=VALUE guard--no-builtin-rulesfor absolute path forwarding), plusbase PR#404 upgrade.sh idempotency regex fix, and other v0.35.0
changes. Workflow
@tagreferences updated to@v0.35.0..hadolint.yamlbreak symlink + add DL3003/DL3006: the basesymlink only carried 4 generic ignores. ros1_bridge's
FROM ${BASE_IMAGE}(DL3006, variable-based multi-distro) andcd /lintin the test stage (DL3003) caused CI failure on everymain-branch push since v0.34.0 upgrade. Standalone file adds the
2 repo-specific rules alongside the 4 inherited base rules.
CHANGELOG
[Unreleased]Fixed entry for the hadolint fix.Test plan
./script/build.sh testgreen (shellcheck + hadolint + 64bats smoke tests).
config/docker/setup.confdiff reviewed -- cosmeticcomment restructuring only, no functional impact on ros1_bridge's
section overrides.
ci-summaryaggregator).Context
including hadolint; PR CI for doc-only changes skips the build
step, masking the failure.