fix(.gitignore): align logging managed block with setup.conf (#115)#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #115. Fixes the stale
/logs/entry in the[logging] local_pathmanaged marker block of.gitignore.PR #114 upgraded
.baseto v0.34.0 and flipped[logging] local_pathfrom
./logs/to./log/inconfig/docker/setup.conf, but themanaged block in
.gitignorewas not updated becausesetup.sh applydid not run after the config change. The v0.34.0 prune mechanism
(base#390) would have fixed this on the next wrapper invocation, but
the stale entry persisted in the meantime.
Audit findings (issue #115)
Full audit of
.gitignoreagainst base's canonical output:bridge.yaml,.claude,CLAUDE.md) valid./logs/stale in managed block (fixed by this PR).Test plan
.gitignorechange:/logs/->/log/.ci-summaryaggregator).Context
The root cause (two-source gitignore lifecycle: init/upgrade vs
runtime) is tracked in ycpss91255-docker/base#402.