chore: upgrade template subtree to v0.29.2#106
Merged
Conversation
6acb8de chore: release v0.29.2 (#353) ccac90a fix(stop): activate all profiles + --remove-orphans + real verbose listing (#341, #345) (#352) ab8ca0d fix(exec): derive precheck container name from -t/--target (#335) (#351) 9f46574 fix(dockerfile): ENV HOME explicit for WORKDIR interpolation in Dockerfile.example (#350) e2af192 chore: release v0.29.1 (#349) c32569a fix(dispatcher): per-shard image_name separator hyphen not underscore (#347) 47bc869 chore: release v0.29.0 (#346) db555ea chore: release v0.29.0-rc1 (#343) 5fc8800 ci(self-test): behavioural job conditional on behavioural_relevant + block-list expansion (#317 P3) (#342) 14d395d feat(ci): multi-distro-build-worker.yaml dispatcher reusable workflow (#325 B-1) (#339) git-subtree-dir: .base git-subtree-split: 6acb8de18db4fa75a9d676526a9289bb01c2e0e7
- main.yaml: workflow @tag updated to v0.29.2 - .gitignore: synced canonical entries (template lib/gitignore.sh) - untracked any derived artifacts now covered by .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Why this fanout
ycpss91255-docker/base@v0.29.2-- 4 small-bug closures sincev0.29.1:#334 Dockerfile.example WORKDIR collapse -- explicit
ENV HOMEdeclared beforeWORKDIR "${HOME}/work"so the directive resolves to/home/<user>/workinstead of silently collapsing to/work. Eliminates the BuildKitWARN: UndefinedVarnoise on every build and fixes non-interactivedocker execcwd. Downstream Dockerfiles need to mirror theENV HOMEline themselves (this PR only updates the template's example, not each downstream's copy) -- this PR-fanout doesn't auto-patch downstream Dockerfiles. Tracked by #348 (upgrade.sh auto-patch).#335![]()
' is not running".
exec.sh -t <non-devel>precheck -- container-name derivation now branches on${TARGET}, mirroring compose.yaml's${USER_NAME}-${IMAGE_NAME}-<stage>${INSTANCE_SUFFIX:-}convention. Before this,./exec.sh -t headless ...against an actually-running headless container aborted with "'#341
stop.shprofile-gated service skip --_down_onenow exportsCOMPOSE_PROFILES='*'(compose v2.32+ wildcard) and passes--remove-orphans, so profile-gated services (headless / gui / test from #215) actually get torn down instead of silently surviving./stop.shwithexit 0.#345
stop.sh -vno-op -- previously exportedBUILDKIT_PROGRESS=plainwhich has zero effect oncompose down. Replaced with real verbose listing -- prints containers belonging to the compose project before tearing them down, in parity with build / run / exec verbose output.Recommendation
All 4 are quality-of-life fixes for users hitting non-default targets (
-t headless,-t gui, etc., from #215). v0.29.2 is the recommended v0.29.x baseline for any downstream consuming the auto-emitted stage feature.Known follow-up
Downstream Dockerfile drift (the missing
COPY .base/script/docker/lib /lint/libline; pre-existing since #284 in v0.28.0) is still patched ad-hoc post-fanout via.claude/scripts/fix-dockerfile-lint-lib.sh --branch chore/template-v0.29.2. Tracked at base#348 for upgrade.sh auto-patch in a future minor.Closes part of ycpss91255-docker/base#334, #335, #341, #345.
What
Bumps
.base/subtree to v0.29.2 via:upgrade.shhandles all four steps automatically:git subtree pull --squashto v0.29.2init.shre-run (symlink resync)main.yaml@tagreferences rewritten to@v0.29.2init.shwas re-run after the upgrade per the project'stemplate subtree upgraderule (rule lives in CLAUDE.md / memory).Verification
Smoke / unit / integration tests run in CI via the standard
call-docker-buildreusable workflow at@v0.29.2.