fix(ci): release-test-tools Dockerfile path (drop subtree prefix)#120
Merged
Conversation
release-test-tools.yaml runs in the template repo itself, not in a downstream consumer, so the Dockerfile lives at dockerfile/... — the template/dockerfile/... path I wrote is what build-worker.yaml sees (that one executes in the downstream's checkout, where template/ is the subtree root). Bootstrap workflow_dispatch run failed with `lstat template: no such file or directory`. Added regression test asserting the path is template-repo-local and no subtree-prefixed path leaks back in.
This was referenced Apr 24, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bootstrap
workflow_dispatchofrelease-test-tools.yamlfailed:release-test-tools.yamlruns in the template repo, soDockerfile.test-toolsis atdockerfile/Dockerfile.test-tools— nottemplate/dockerfile/Dockerfile.test-tools(that's the subtree path downstream consumers see, used bybuild-worker.yamlwhich executes in a downstream's checkout).Changes
.github/workflows/release-test-tools.yaml:template/dockerfile/→dockerfile/+ comment explaining the path asymmetry.test/unit/template_spec.bats: regression test asserting the template-repo-local path and no subtree prefix leak.TEST.md: 663 → 664.Test plan
make -f Makefile.ci testlocal — 664/664 passrelease-test-tools.yamlviaworkflow_dispatch→ pushesghcr.io/ycpss91255-docker/test-tools:latestsuccessfully