Ben omp #7
Merged
Ben omp #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid the need to cross compile for macOS, though M1 runners have only 7GB of RAM.
This does 2 things: 1. When compiling assembly files (.S), specify the cross-compilation flags. This fixes the build of openmp, which has a cute little asm file, curiously named "Linux" but applies to Unix and Windows too. 2. Makes compiling x86_64 from an arm64 mac actually work, rather than just silently building arm64 objects and putting them in a directory named x86_64.
|
Thanks for helping with this. I'm merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build openmp
This change is