Merged
Conversation
* Fetch Copilot CLI at build time * Update tests to use bundled CLI * Always get from NPM * CR feedback * Node: use bundled CLI * Bundling for Python * Formatting * Update test_client.py * Python test fix * Consistent node version for CI * Make publish.yml safer - don't actually deploy to package managers if running on a branch * Fix license file
- Add ignore_errors=True to shutil.rmtree() in test cleanup to handle race conditions where files are still being written by background processes - Add missing_ok=True to unlink() for same reason - Add pytest-timeout to dev dependencies (fixes warning about unknown mark)
* Fix .NET SDK package missing props file The _GenerateVersionProps target was running BeforeTargets=BeforeBuild, but dotnet pack evaluates ItemGroup wildcards before targets run. This meant the generated .props file wasn't being included in the package. Fixed by: 1. Adding Pack to BeforeTargets so the target runs before packing 2. Explicitly adding the props file to pack content inside the target 3. Changing the static ItemGroup to only include the .targets file * Pass --no-auto-update to CLI across all SDKs Prevents the CLI from auto-updating itself, ensuring the version bundled with the SDK is the version that runs.
… no reason to rely on it being at that exact path.
* use types to encode and decode jsonrpc queries * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * reexport some types * fix race * fix test * export PingResponse * use SendAndWait instead of GetFinalAssistantMessage * fix nil access * fix nil access * fix nil access * fix nil access * fix race * remove if * remove getFinalAssistantMessage from nodejs test harness * revert test changes --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Upstream: github/copilot-sdk@05e3c46 ACP auto-resolved: false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream sync - 9 commits from github/copilot-sdk