Skip to content

Use standard ACP session/set_config_option#7

Merged
yazelin merged 1 commit intomainfrom
fix/use-standard-acp-config-option
Feb 6, 2026
Merged

Use standard ACP session/set_config_option#7
yazelin merged 1 commit intomainfrom
fix/use-standard-acp-config-option

Conversation

@yazelin
Copy link
Copy Markdown
Owner

@yazelin yazelin commented Feb 6, 2026

Summary

  • Replace non-standard session/set_model with ACP standard session/set_config_option method
  • Update types: replace Gemini-specific AcpSetModelParams/AcpSetModeParams with generic AcpSetConfigOptionParams
  • Make invalid model detection a soft check in demo tests (ACP spec does not require servers to reject invalid models)

Test plan

  • 57 ACP unit tests pass
  • Gemini demo: 15/16 pass (step12 flaky LLM memory test)
  • Claude demo: 16/16 pass

🤖 Generated with Claude Code

…ssion/set_model

session/set_model was a Gemini-specific method not part of the ACP spec.
The standard method is session/set_config_option with configId + value params.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@yazelin yazelin merged commit 6c223de into main Feb 6, 2026
9 of 12 checks passed
@yazelin yazelin deleted the fix/use-standard-acp-config-option branch February 6, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant