Skip to content

Make #candidate_device? public#1410

Merged
joseivanlopez merged 2 commits into
yast:masterfrom
joseivanlopez:candidate-device
May 13, 2025
Merged

Make #candidate_device? public#1410
joseivanlopez merged 2 commits into
yast:masterfrom
joseivanlopez:candidate-device

Conversation

@joseivanlopez
Copy link
Copy Markdown
Contributor

Problem

Agama needs to check whether a device (drive or MD RAID) can be used as candidate for installation, but the method is private.

Needed for agama-project/agama#2338.

Solution

Make DiskAnalyzer#candidate_device? public.

@coveralls
Copy link
Copy Markdown

coveralls commented May 13, 2025

Coverage Status

coverage: 97.77%. remained the same
when pulling a596e26 on joseivanlopez:candidate-device
into 8889433 on yast:master.

Copy link
Copy Markdown
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit e1e1ab1 into yast:master May 13, 2025
7 checks passed
@github-actions
Copy link
Copy Markdown

✅ Autosubmission job #14998830807 successfully finished
✅ Created submit request #1277170

joseivanlopez added a commit to agama-project/agama that referenced this pull request May 14, 2025
Extend storage schema with more search conditions:

* Drives and MD RAIDs: by name, by size (equal, greater or less).
* Partitions: by name, by size (equal, greater or less), by partition
number.

Requires yast/yast-storage-ng#1410.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants