Tiny internal code reorganization to ease Agama development#1386
Merged
ancorgs merged 3 commits intoyast:masterfrom Aug 21, 2024
Merged
Tiny internal code reorganization to ease Agama development#1386ancorgs merged 3 commits intoyast:masterfrom
ancorgs merged 3 commits intoyast:masterfrom
Conversation
05d3821 to
1261f2a
Compare
bb88874 to
3318e23
Compare
3318e23 to
df46976
Compare
df46976 to
6630f78
Compare
|
✅ Autosubmission job #10491232500 successfully finished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agama-project/agama#1448 introduces a new approach to manage storage devices at Agama. Instead of relying on the Y2Storage proposals living in this repository, that PR introduces a new
Y2Storage::AgamaProposalclass living at the Agama repository.That new proposal needs to:
SpaceMakerdoes not clean up the attribute#forced_ptable_typefor all devices just for the sake of it (it doesn't seem to be a clear need for such initialization).All that could be fixed on the Agama side:
SpaceMakermethod can be redefined by the Agama proposal to leave out the excessive initialization.But this PR offers an alternative by modifying the code directly at the yast2-storage-ng repository, which may be considered cleaner.