zFCP refactoring needed for Agama#105
Merged
joseivanlopez merged 3 commits intoyast:masterfrom Jun 9, 2023
Merged
Conversation
joseivanlopez
force-pushed
the
agama-zfcp
branch
3 times, most recently
from
b387aab to
32c8dc2
Compare
joseivanlopez
changed the title
joseivanlopez
changed the title
joseivanlopez
force-pushed
the
agama-zfcp
branch
3 times, most recently
from
86f9b6a to
2f0de83
Compare
dgdavid
approved these changes
Jun 9, 2023
Member
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
Looks good to me. Just two silly questions.
Contributor
|
✔️ Public Jenkins job #42 successfully finished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ZFCPControllermodule allows managing zFCP devices, but its code mixes UI and zFCP management logic. That makes very diffucult to reuse its functionality from outsize of YaST (e.g., Agama).Solution
Create a new separate class (
Y2S390::ZFCP) which offers the core functionality for managing zFCP devices. TheZFCPControlleris adapted to delegate running commands to the new class.The new
Y2S390::ZFCPclass is also used by Agama in order to provide a zFCP D-Bus API, see agama-project/agama#594.Testing