Prevent Crash if Closing the DASD Context Menu without Action [SLE-15-SP5]

[shundhammer]

Target Branch / Release

This is for SLE-15-SP5. The merge to master is #104.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1211213

Problem

Closing the context menu of the DASD list without executing any of its actions (e.g. by clicking outside the context menu or with the [Esc] key) caused a hard crash:

uninitialized constant Y2S390::DasdActions::Cancel

Cause

The UI.YContextMenu used here sends a CancelEvent (ID :cancel) when the user closes the menu without action. The yast-s390 code simply converted the received ID into a Ruby symbol for an action class to be executed and tried to run that class.

Fix

• Now explicitly catching action :cancel and ignoring it.

• Now generally checking if there actually is an action class for that symbol and logging an error instead of just crashing:

2023-05-10 15:20:39 <3> balrog(19572) [Ruby] dasd/dialogs.rb(rescue in run):150 No action for cancel: uninitialized constant Y2S390::DasdActions::Cancel

Test

Manual test with mocked data as described here:

• Selecting a DASD from the list and opening the context menu
• Clicking outside the context menu to close it
• Opening it again and using the Esc key to close it

No complaint should appear in the log for this :cancel action.

• Commented out the new return false if action == :cancel line and trying again: Now there should be an error in the y2log No action for cancel: uninitialized constant Y2S390::DasdActions::Cancel.

Other affected Places in YaST

This one place in the yast2-s390 DASD handling is really the only place (that we found) all over YaST where we use that YContextMenu, so the problem should not appear anywhere else.

Fix in the UI

The behavior of that YContextMenu is very weird. Closing a menu without any action should never send any event (i.e. make UI.UserInput() return any value); it should just silently close the menu, and that should be it.

But that behavior has been unchanged since 15 years ago, so there is the slight chance that other Open Source software which uses libyui may be affected. But sending a CancelEvent in that case is almost certainly always unwelcome, so fixing it also in our own upstream libyui-qt should only be an improvement.

Related PR

• Merge to master: Prevent Crash if Closing the DASD Context Menu without Action [master] #104

[coveralls]

Coverage: 21.262% (-0.02%) from 21.282% when pulling 3aa139e on huha-fix-context-menu into 68ae06f on SLE-15-SP5.

[teclator]

LGTM

[yast-bot]

✔️ Internal Jenkins job #757 successfully finished
✔️ Created IBS submit request #297459

[yast-bot]

✔️ Internal Jenkins job #758 successfully finished
✔️ Created IBS submit request #297628