drop unused reports (see https://github.com/openSUSE/libzypp/pull/610)#191
Conversation
jreidinger
force-pushed
the
drop_unused_report
branch
2 times, most recently
from
c2b1b9b to
a087997
Compare
lslezak
left a comment
lslezak
left a comment
There was a problem hiding this comment.
Please add logging so we can find the callers and update them.
| YCPValue PkgFunctions::CallbackSourceCreateStart( const YCPValue& args) | ||
| { | ||
| return SET_YCP_CB( CB_SourceCreateStart, args); | ||
| return YCPVoid(); |
There was a problem hiding this comment.
I'd add some logging to easily find the obsolete calls in the Ruby code:
ycpmilestone("Pkg::CallbackSourceCreateStart is obsolete and does nothing, remove it");This logs the Ruby place where it was called from.
(Needs #include <ycp/y2log.h> at the top.)
There was a problem hiding this comment.
looks like there is already #include "log.h" which should include y2util/y2log which hopefully should be enough.
There was a problem hiding this comment.
hmm, it defined y2milestone and not ycpmilestone. Let me check if there is difference between them.
There was a problem hiding this comment.
ok, there is different y2milestone report file nad location when it is called. ycpmilestone will use yast info about location, so probably the right ruby location. So lets add that header.
jreidinger
force-pushed
the
drop_unused_report
branch
from
0306535 to
b0ffbf0
Compare
|
✅ Autosubmission job #13110415173 successfully finished |
## Problem Agama only implements a few libzypp error callbacks, so many times it does not report problems properly. ## Solution Implement more libzypp error callbacks, reporting more types of problems. - [x] DoneProvide - ~~SourceProbeError~~ - not used - ~~SourceCreateError~~ - not used - [x] ScriptProblem - [x] DonePackage for not used see yast/yast-pkg-bindings#191 ## Testing - Tested manually, testing the package installation failure was a bit tricky. I used `dd if=/dev/zero of=/mnt/eat-space` to eat all available space. But you need to leave enough space for download and not enough to install the package. ## Future - AcceptUnknownGpgKey - AcceptVerificationFailed - AcceptFileWithoutChecksum - AcceptWrongDigest - AcceptUnknownDigest ## Screenshots 
2 participants
Problem
Libzypp has bunch of unused reports and pkg-bindings still use it.
openSUSE/libzypp#610
Solution
make them noop and mark as deprecated.