Merged
Conversation
2 tasks
imobachgs
force-pushed
the
add-skip-profile-fetch-error
branch
2 times, most recently
from
ce5939a to
f0ac162
Compare
imobachgs
force-pushed
the
add-skip-profile-fetch-error
branch
from
f0ac162 to
b03bfb9
Compare
Member
|
NP: Do we plan an env variable for disabling the search completely? |
mchf
approved these changes
Mar 21, 2025
dgdavid
approved these changes
Mar 21, 2025
Contributor
Author
Not at this point. We just want to be able to silently fail in this case. |
|
✅ Autosubmission job #13993237386 successfully finished |
imobachgs
added a commit
to agama-project/agama
that referenced
this pull request
Mar 24, 2025
## Problem Linuxrc & AutoYaST used to load profiles from predefined locations automatically. Some customers and partners depend on such behavior, so Agama should behave in the same way. ## Solution If no URL was given, Agama tries to load the profile from the following locations: - An `autoinst.jsonnet`, `autoinst.json` and `autoinst.xml` files located on a file system labeled as `OEMDRV`. - An `autoinst.jsonnet`, `autoinst.json` and `autoinst.xml` files in the root file system. ## Testing - *Tested manually* ## To do - [x] Do not report an error if any of the fallback profiles do not work (see yast/yast-autoinstallation#882). - [x] Read profiles from the predefined locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the environment variable
YAST_SKIP_PROFILE_FETCH_ERRORis set to "1", the error is skipped.Problem
Agama tries to fetch the profiles from predefined locations if no URL is given. See agama-project/agama#2180 for further details.
The problem is that, when the profile does not exist, the AutoYaST code reports an error and it should not do it because it is expected to search for those profiles silently.
Solution
Allow to disable the error by setting the environment variable
YAST_SKIP_PROFILE_FETCH_ERROR.Testing