-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README with workaround for error caused by length requirement on token property even if not required by server #63
Conversation
Hey, thank you for participating with this. It's really quite painfully missed info within the docs. But could you also please add kinda same note into |
Sure, no problem! How about adding a new "Known Issues" section right before "Disclaimers"? Explain how to implement the workaround there, and link it up to an actual repo issue which actually details the underlying cause. Then just briefly mention the issue where relevant and reference the full explanation. Allows the fix to be more prominent without adding too much extra noise. I'll tinker with it a little and add some suggestions :) |
…en when using local provider with no auth required. Squashed commit of the following: commit 92d5e6a Author: Knut Leborg <[email protected]> Date: Sun Oct 13 13:14:50 2024 +0200 Update README.md commit 750dcae Author: Knut Leborg <[email protected]> Date: Sun Oct 13 13:11:00 2024 +0200 Update README.md commit fe7650c Author: Knut Leborg <[email protected]> Date: Sun Oct 13 13:07:52 2024 +0200 Update README.md commit 0e16178 Author: Knut Leborg <[email protected]> Date: Sun Oct 13 13:01:34 2024 +0200 Update README.md Add a quick note to explain a workaround for incorrect token error even when using local provider with no auth required.
See issue #64 for a detailed description of problem cause, current workaround, and other relevant info |
… mentions including a reference to details to relevant README sections, as well as default sublime-settings template
let me know if i missed something ✌️ |
Thank you for such thorough PR. The only thing that catches my eye here is that I consider as no go to ask a user to go to GitHub issues to get the answer of how to fix the error they're got, so I'd add this very comment in the settings after all But if you're gonna to fix the issue completely soon, I'm ok with how it's going as well. |
Updated the comment in the config file as suggested since I might not have time to fix the issue for a little while after all, sorry 😅 |
No worries, there is no rush here. Thank you for the participation with docs. |
Add a quick note to explain a workaround for incorrect token error even when using local provider with no auth required.
Root cause seems to be the string length check on token at plugins/openai_worker.py:471
Should be a fairly quick fix depending on how you prefer to handle it, but I'd probably suggest something like disabling the length check if token value is explicitly set to Null rather that empty string just for simplicity.
Anyways, I figured a little heads up added to the readme would have saved me a bit of head-scratching, while still being fairly low-effort in case you already have plans for a long term fix, so here it is :)