Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: handle empty bin strings #6515

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Fix: handle empty bin strings #6515

merged 4 commits into from
Oct 9, 2018

Commits on Oct 7, 2018

  1. Fix: handle empty bin strings 

    When the package.json of a dependency sets `bin` to an empty string,
do not normalize it. This prevents creating a symlink to the
dependency's root directory within the `.bin` directory if bin-links
are enabled
    @rhburrows
    rhburrows committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    88759f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2018

  1. Add an entry to the changelog

    @rhburrows
    rhburrows committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    610daba View commit details
    Browse the repository at this point in the history

  2. Add a test to make sure empty binlinks aren't created 

    Test was suggested/provided by @rally25rs
    @rhburrows
    rhburrows committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    3571127 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. Fix empty bin string test on Windows

    @rhburrows
    rhburrows committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    ad9420f View commit details
    Browse the repository at this point in the history