Return registry from URL when requesting a file #1561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures authentication options are passed to these requests. fixes #1318
dfreeman
reviewed
Nov 3, 2016
| getRegistry(packageName: string): string { | ||
| // If this is a request for a file, return the registry from the URL | ||
| if (HTTPS_EXPRESSION.test(packageName)) { | ||
| const registryProtocolHost = packageName.match(/^https?:\/\/[^\/]+\//i); |
There was a problem hiding this comment.
This only matches on the protocol + hostname. An npm registry URL can also include a path, e.g. for registries that are part of a larger artifact hosting application, like Nexus or Artifactory.
|
Thanks for the PR, the case is covered in a bit more generic way in #1666. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures authentication options are passed to these requests.
Fixes #1318