Support auth for private npm packages #1146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
reviewed
Oct 17, 2016
src/registries/npm-registry.js
Outdated
| const alwaysAuth = this.getScopedOption(registry.replace(/^https?:/, ''), 'always-auth') | ||
| || this.getOption('always-auth'); | ||
| || this.getOption('always-auth') | ||
| || removePrefix(requestUrl, registry)[0] === '@'; |
There was a problem hiding this comment.
the code style should be to intend two spaces from const.
Sends the auth token for scoped packages, which may be private. Fixes yarnpkg#1134 and yarnpkg#521.
devongovett
force-pushed
the
npm-private
branch
from
5acd2b9 to
ae3f72c
Compare
|
Any timeline on a patch release for this (0.15.2)? |
|
Is this released? I'm still getting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sends the auth token for scoped packages, which may be private. Fixes #1134 and #521.
Test plan
Tested installing a private package on the public registry without
always-authin .npmrc.