-
Notifications
You must be signed in to change notification settings - Fork 1k
Add post announcing new custom-host-suffix option #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed a typo and added a suggestion
|
|
||
| Starting with version `0.26.0`, Yarn now understands a new configuration option called `custom-host-suffix`. This allows you to keep the same strict URL validations for most of your package URLs but also selectively loosen that check for a specific registry provider so that Yarn will now match the URLs where the host part ends with the value from this new option. | ||
|
|
||
| Simply add `custom-host-suffix` to either your global user-level `.npmrc` or your project's individual `.npmrc` and Yarn will be able to download your packages as desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about .yarnrc with an example?
yarn config set custom-host-suffix <url>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bestander The custom-host-suffix actually does not work with .yarnrc right now, as far as I can tell.
I think npm-registry.js only loads config values from .npmrc: https://github.com/yarnpkg/yarn/blob/master/src/registries/npm-registry.js#L132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but there us yarn-registry that inherits from npm-registry and reads .yarnrc.
Could you please check if yarnrc works as well?
I expect that it should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm - doesn't work to add custom-host-suffix to .yarnrc with 0.26.0-20170524.1610. Had to put it into .npmrc and haven't investigated further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's merge as is and iterate further
|
Thanks, @lumaxis! |
|
@bestander Maybe modify the post date so it can come on top as the newest post? |
|
Go ahead, send a PR
…On Thu, 15 Jun 2017 at 20:37, G. Kay Lee ***@***.***> wrote:
@bestander <https://github.com/bestander> Maybe modify the post date so
it can come on top as the newest post?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#504 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACBdWDIl8IQqamg6h8c6iHUm1y2gyfpJks5sEe47gaJpZM4NfYib>
.
|
|
@gsklee @bestander Added #530 |
As discussed with @bestander in yarnpkg/yarn#3231, I added a quick post explaining the new feature.
I don't really know what the guidelines are for the posts on your blog so I tried to align myself to some of the previous ones. Feel free to criticize or change anything as it makes sense to you 👍