feat: use nodejs-built-in-modules crate to remove duplicated code#81
Merged
feat: use nodejs-built-in-modules crate to remove duplicated code#81
Conversation
Contributor
Benchmark for 67901c7Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the local
src/builtins.rsmodule with thenodejs-built-in-modulescrate to eliminate code duplication and leverage a shared, up-to-date list of Node.js built-in modules.Motivation
This change is part of an effort to remove duplicated code across the Rust ecosystem, similar to the work done in oxc-project/oxc-resolver#940.
Multiple Rust projects were maintaining their own hardcoded lists of Node.js built-in modules, which:
Benefits
Updated Node.js v24 support: The crate includes newly added Node.js v24 built-in modules like:
inspector/promiseswasi_http_*,_stream_*,_tls_*)Handles
node:prefix requirement: The crate correctly handles the built-in modules with mandatorynode:prefix:seasqlitetesttest/reportersReduces maintenance: Future updates to Node.js built-in modules only require updating the shared crate version.
Code reduction: Removes ~60 lines of duplicated code from this repository.
Changes
nodejs-built-in-modules = "0.0.1"dependencysrc/builtins.rsfilesrc/lib.rsto usenodejs_built_in_modules::is_nodejs_builtin_module()Testing
All existing tests pass: