docs: fix npmMinimalAgeGate default value.#7125
Conversation
|
@clemyan I pushed the docs fix then. |
| { "type": "string", "pattern": "^(\\d*\\.?\\d+)(ms|s|m|h|d|w)?$" } | ||
| ], | ||
| "default": "3d" | ||
| "default": "0m" |
There was a problem hiding this comment.
| "default": "0m" | |
| "default": "0m", | |
| "examples": ["3d"] |
There was a problem hiding this comment.
Perhaps we could append 1w too?
|
hi there, maybe I miss something but isn't the default value for |
|
@PierreNoll this PR was opened before #7135 (you can see by PR number), I think there was a concurrent problem. What is wierd is why this PR didn't cause any conflict with Master... |
|
btw the iniciative of this PR was to upgrade to 3d, some recommended value on other package managers because the security issues... |
|
ping @clemyan #7125 (review) I though by enabling a minal age would be a huge breaking change xDDDDD |
|
It would have been a breaking change had we not been careful. It was not done lightly, so it worked out. |
What's the problem this PR addresses?
according the documentation https://github.com/ryanfox1985/berry/blob/fix_default_parameter/packages/docusaurus/static/configuration/yarnrc.json#L506
The default parameter is 3 days and current code doesn't apply any default.
How did you fix it?
Just appending the default value.
Checklist