-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for catalog references in peer dependencies #6926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi, |
|
I'm not certain that's correct - afaik the |
I'm not very familiar with reduceDependency, do you think the fundamental solution would be to fix reduceDependency so that it iterates over peerDependencies as well? |
|
Hey, |
|
I've been busy and haven't been able to get to the PR. I'll work on it by next weekend! |
|
@arcanis @MKruschke Hello! I've added a reducePeerDependency hook and test code. Verified that it works. Happy to get a review! |
What's the problem this PR addresses?
Fixes: #6925
Adds support for
catalog:protocol inpeerDependencies. Previously, catalog references in peer dependencies were incorrectly reported. This change allows catalog references to be used in peerdependencies, consistent with their support in other dependency types.
...
How did you fix it?
Updated the dependency range validation logic in
Manifest.tsto treatcatalog:protocol as a valid range format. This prevents catalog references from beingflagged as errors when used in peer dependencies.
...
Checklist