Skip to content

feat: support auth in proxy url#4243

Merged
arcanis merged 1 commit intoyarnpkg:masterfrom
Leksat:3684-proxy-auth
Mar 29, 2022
Merged

feat: support auth in proxy url#4243
arcanis merged 1 commit intoyarnpkg:masterfrom
Leksat:3684-proxy-auth

Conversation

@Leksat
Copy link
Copy Markdown
Contributor

@Leksat Leksat commented Mar 18, 2022

What's the problem this PR addresses?

Adds support for proxy URLs containing auth credentials. For example, http://<username>:<password>@proxy.com:1234

Closes #3684

How did you fix it?

It's really two lines of code. Take the credentials from the URL and pass them to the tunnel library.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@Leksat Leksat requested a review from arcanis as a code owner March 18, 2022 08:46
@Leksat
Copy link
Copy Markdown
Contributor Author

Leksat commented Mar 21, 2022

@arcanis windows-latest w/ Node.js 17.x failed with a timeout. Could you please restart it? Previous time it worked.

@arcanis arcanis merged commit 80a1c28 into yarnpkg:master Mar 29, 2022
@arcanis
Copy link
Copy Markdown
Member

arcanis commented Mar 29, 2022

Thanks!

@Leksat Leksat deleted the 3684-proxy-auth branch March 29, 2022 12:28
@jaunusa
Copy link
Copy Markdown

jaunusa commented Sep 16, 2022

Is it possible to merge this feature to yarn 3? Otherwise I have to upgrade to rc.18.

@arcanis
Copy link
Copy Markdown
Member

arcanis commented Sep 16, 2022

Upgrading to RC should be perfectly fine. RCs are just a way to indicate we may still land a couple of breaking changes; in terms of stability, they're at least as good as stable builds.

@jaunusa
Copy link
Copy Markdown

jaunusa commented Sep 16, 2022

Good to know, I was wondering why my container crashes while running yarn install (rc.18) in a kubernetes environment. So in that case I'll trust you and will search for a different reason ;)
Thank you for the reply

merceyz pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Http proxy basic-auth

3 participants