feat: support auth in proxy url#4243
Merged
arcanis merged 1 commit intoyarnpkg:masterfrom Mar 29, 2022
Merged
Conversation
Contributor
Author
|
@arcanis |
Member
|
Thanks! |
|
Is it possible to merge this feature to yarn 3? Otherwise I have to upgrade to rc.18. |
Member
|
Upgrading to RC should be perfectly fine. RCs are just a way to indicate we may still land a couple of breaking changes; in terms of stability, they're at least as good as stable builds. |
|
Good to know, I was wondering why my container crashes while running |
merceyz
pushed a commit
that referenced
this pull request
Oct 21, 2023
(cherry picked from commit 80a1c28)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Adds support for proxy URLs containing auth credentials. For example,
http://<username>:<password>@proxy.com:1234Closes #3684
How did you fix it?
It's really two lines of code. Take the credentials from the URL and pass them to the
tunnellibrary.Checklist