Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pnp): pnpapi isn't lost on virtual path portals #1963

Merged
merged 4 commits into from
Oct 12, 2020

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Oct 10, 2020

What's the problem this PR addresses?

When I opened #1851 I didn't add a test

Fixes #1851 (comment)

How did you fix it?

Added a test

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit e5742a7 into master Oct 12, 2020
@arcanis arcanis deleted the merceyz/pnp-portal-test branch October 12, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants