Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): implement caFilePath and enableStrictSsl #1934

Merged
merged 4 commits into from
Oct 7, 2020
Merged

feat(core): implement caFilePath and enableStrictSsl #1934

merged 4 commits into from
Oct 7, 2020

Conversation

andreialecu
Copy link
Contributor

@andreialecu andreialecu commented Oct 6, 2020 •
edited
Loading

What's the problem this PR addresses?

Fixes #798

How did you fix it?

Added caFilePath configuration option. Works similar to yarn v1's cafile option.

Added enableStrictSsl configuration option. Defaults to true. Setting it to false will bypass certificate errors.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@andreialecu andreialecu requested a review from arcanis as a code owner October 6, 2020 14:48
arcanis
arcanis approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@arcanis arcanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good diff! Since it touches something I've never worked with I'd like to get a second approval, but as far as the general idea goes everything looks like how I'd have implemented it 👍

@andreialecu andreialecu mentioned this pull request Oct 6, 2020
Closed
@arcanis arcanis merged commit 64dffde into yarnpkg:master Oct 7, 2020
arcanis pushed a commit that referenced this pull request Oct 7, 2020
@andreialecu @arcanis
feat(core): implement caFilePath and enableStrictSsl (#1934)
1723414 
* feat(core): implement `caFilePath` and `enableStrictSsl`

* cleanup

* bump cli

* remove @types/got and fix deprecation wraning
@merceyz merceyz mentioned this pull request Oct 7, 2020
Merged
3 tasks
@manolakis
Copy link

Awesome! 💪

@dkelly99 dkelly99 mentioned this pull request Nov 26, 2020
Closed
1 task
@merceyz merceyz mentioned this pull request Jan 2, 2021
Closed
@shmuli9
Copy link

shmuli9 commented Jan 19, 2021

Thanks @andreialecu you've saved the day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcanis arcanis arcanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@andreialecu @manolakis @shmuli9 @arcanis