Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
There are 2 code paths here:
berry/packages/yarnpkg-cli/sources/main.ts
Line 64 in 215455f
The
--cwd
option is only checked for on theelse
branch, so whenrun
is called after--cwd
is encountered, there is a possibility that theif
branch will execute with the--cwd
option that was already encountered.This causes commands to be executed in the wrong directory in some cases.
This PR closes #1056.
How did you fix it?
I made the
--cwd
flag and its argument get removed fromprocess.argv
when--cwd
is encountered.